Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memory size flag to activate dyn queue size feature #2059

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Use memory size flag to activate dyn queue size feature #2059

merged 1 commit into from
Feb 7, 2020

Conversation

jpkrohling
Copy link
Contributor

Which problem is this PR solving?

  • One more place was using the warmup flag to activate the dynamic queue size. This PR changes that to use the dynQueueSizeMemory value instead, as it's the only one explicitly set by users.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling jpkrohling requested a review from a team as a code owner February 6, 2020 13:40
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although need to fix ci.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c29449a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2059   +/-   ##
=========================================
  Coverage          ?   97.41%           
=========================================
  Files             ?      207           
  Lines             ?    10307           
  Branches          ?        0           
=========================================
  Hits              ?    10041           
  Misses            ?      223           
  Partials          ?       43
Impacted Files Coverage Δ
cmd/collector/app/span_processor.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29449a...6dbbaeb. Read the comment docs.

@jpkrohling jpkrohling merged commit 29e7131 into jaegertracing:master Feb 7, 2020
@jpkrohling jpkrohling deleted the MemorySizeFlagInNewSpanProcessor branch July 28, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants