Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] Do not increment data loss counters on the first client batch #2028

Merged

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

In #2010, the counters are always incremented by the delta from current client stats and the previously recorded values. However, when previous values are zero, as could be the case when the client has been running for a while but agent was just restarted, the delta could be very large and not reflective of the incremental change since the previous batch (which the agent did not see), causing massive spikes in metrics and messing up the totals.

Short description of the changes

  • Stats from the first batch are captured, but not applied as deltas to the counters.

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #2028 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2028      +/-   ##
==========================================
+ Coverage   97.41%   97.41%   +<.01%     
==========================================
  Files         207      207              
  Lines       10247    10249       +2     
==========================================
+ Hits         9982     9984       +2     
  Misses        222      222              
  Partials       43       43
Impacted Files Coverage Δ
cmd/agent/app/reporter/client_metrics.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886b965...1a054d4. Read the comment docs.

@yurishkuro yurishkuro merged commit eea26e9 into jaegertracing:master Jan 17, 2020
@yurishkuro yurishkuro deleted the suppress-initial-metrics-spike branch January 17, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants