Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed the requirements for the test TestResizeOldQueueIsDrained #2007

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Relaxed the requirements for the test TestResizeOldQueueIsDrained #2007

merged 1 commit into from
Jan 7, 2020

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

Short description of the changes

  • Relaxed the expectations around consumed/dropped items when the queue is being drained. There might be cases where a few more items exist in the combined queues than the desired capacity, but this situation is more desirable than ensuring consistency at the cost of performance.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #2007 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2007   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files         205      205           
  Lines       10114    10114           
=======================================
  Hits         9806     9806           
  Misses        269      269           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009b7f5...e79e191. Read the comment docs.

@yurishkuro yurishkuro merged commit 08a0a4b into jaegertracing:master Jan 7, 2020
@jpkrohling jpkrohling deleted the 1997-TestResizeOldQueueIsDrained branch July 28, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable test pkg/queue/TestResizeOldQueueIsDrained
2 participants