Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate tchannel reporter flags #1978

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Deprecate tchannel reporter flags #1978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/agent/app/reporter/tchannel/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@ func AddFlags(flags *flag.FlagSet) {
flags.String(
tchannelPrefix+hostPort,
"",
"comma-separated string representing host:ports of a static list of collectors to connect to directly (e.g. when not using service discovery)")
"(deprecated) comma-separated string representing host:ports of a static list of collectors to connect to directly (e.g. when not using service discovery)")
flags.Int(
tchannelPrefix+discoveryMinPeers,
defaultMinPeers,
"if using service discovery, the min number of connections to maintain to the backend")
"(deprecated) if using service discovery, the min number of connections to maintain to the backend")
flags.Duration(
tchannelPrefix+discoveryConnCheckTimeout,
defaultConnCheckTimeout,
"sets the timeout used when establishing new connections")
"(deprecated) sets the timeout used when establishing new connections")
flags.Duration(
tchannelPrefix+reportTimeout,
time.Second,
"sets the timeout used when reporting spans")
"(deprecated) sets the timeout used when reporting spans")
// TODO remove deprecated in 2.0
flags.String(
collectorHostPort,
Expand Down