Improve migration script #1946
Merged
Improve migration script #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- continue migration if number of rows changed during migration - improve the sample command and remove unused TTL since it will be copied from old table Signed-off-by: Jun Guo <guo0693@gmail.com>
guo0693
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 199 199
Lines 9875 9875
=======================================
Hits 9723 9723
Misses 116 116
Partials 36 36Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copied from old table
Signed-off-by: Jun Guo guo0693@gmail.com
Which problem is this PR solving?
Short description of the changes
copied from old table