Support custom basepath in HotROD #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
jan25
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
- Coverage 98.45% 96.97% -1.49%
==========================================
Files 198 203 +5
Lines 9740 10062 +322
==========================================
+ Hits 9590 9758 +168
- Misses 114 266 +152
- Partials 36 38 +2
Continue to review full report at Codecov.
|
albertteoh
reviewed
Nov 11, 2019
|
@albertteoh Thanks for the review! I like your idea about using |
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
|
Hi @pavolloffay @yurishkuro! could you please review this? This is a simple change :) |
pavolloffay
changed the title
pavolloffay
approved these changes
Dec 13, 2019
examples/hotrod/cmd/root.go
Outdated
| @@ -73,6 +75,9 @@ func init() { | |||
| RootCmd.PersistentFlags().IntVarP(&frontendPort, "frontend-service-port", "f", 8080, "Port for frontend service") | |||
| RootCmd.PersistentFlags().IntVarP(&routePort, "route-service-port", "r", 8083, "Port for routing service") | |||
|
|
|||
| // Flag for serving frontend at custom basepath url | |||
| RootCmd.PersistentFlags().StringVarP(&basepath, "basepath", "b", "", "Basepath for frontend service") | |||
There was a problem hiding this comment.
Could you please add a default value / it makes the help command more self explanatory.
-b, --basepath string Basepath for frontend service (default "/")
instead of
-b, --basepath string Basepath for frontend service
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
pavolloffay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
localhost:8080/hotrodShort description of the changes
basepathargument tocmd/root.goTODO