Add documentation how the current badger storage is modeled #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Signed-off-by: Michael Burman <yak@iki.fi>
|
I wonder if it wouldn't make more sense to have storage-specific pages in the main documentation. We do have quite a few details worth documenting for each one of them. |
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
=========================================
- Coverage 98.44% 98.4% -0.05%
=========================================
Files 197 197
Lines 9631 9631
=========================================
- Hits 9481 9477 -4
- Misses 114 117 +3
- Partials 36 37 +1
Continue to review full report at Codecov.
|
|
@jpkrohling The aim here is to provide some design docs to help with maintaining the code. So not sure relevant for the user docs, but did you have a different place in mind? |
yurishkuro
approved these changes
Oct 14, 2019
objectiser
approved these changes
Oct 14, 2019
radekg
pushed a commit
to Klarrio/jaeger
that referenced
this pull request
Oct 28, 2019
…acing#1859) Signed-off-by: Michael Burman <yak@iki.fi> Signed-off-by: radekg <radek@gruchalski.com>
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
…acing#1859) Signed-off-by: Michael Burman <yak@iki.fi> Signed-off-by: Jonah Back <jonah@jonahback.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@objectiser