Use correct context on ES search methods #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
rubenvp8510
force-pushed
the
propagate-context-reader
branch
from
1c79236
to
597e791
Compare
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
rubenvp8510
force-pushed
the
propagate-context-reader
branch
from
597e791
to
260954a
Compare
yurishkuro
approved these changes
Oct 10, 2019
rubenvp8510
force-pushed
the
propagate-context-reader
branch
from
a6f289e
to
34b46d9
Compare
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
rubenvp8510
force-pushed
the
propagate-context-reader
branch
from
34b46d9
to
3cfbccb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
+ Coverage 98.42% 98.44% +0.02%
==========================================
Files 197 197
Lines 9633 9631 -2
==========================================
Hits 9481 9481
+ Misses 116 114 -2
Partials 36 36
Continue to review full report at Codecov.
|
pavolloffay
approved these changes
Oct 10, 2019
radekg
pushed a commit
to Klarrio/jaeger
that referenced
this pull request
Oct 28, 2019
* Use correct context on ES search methods Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Updte reader tests, now expect valueCtx Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> Signed-off-by: radekg <radek@gruchalski.com>
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
* Use correct context on ES search methods Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Updte reader tests, now expect valueCtx Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> Signed-off-by: Jonah Back <jonah@jonahback.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com
Which problem is this PR solving?
Short description of the changes