Add elasticsearch version configuration to rollover script #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
objectiser
reviewed
Sep 2, 2019
| @@ -103,7 +104,7 @@ def perform_action(action, client, write_alias, read_alias, index_to_rollover, t | |||
| sys.exit(1) | |||
|
|
|||
|
|
|||
| def create_index_template(template, template_name, esVersion): | |||
| def create_index_template(template, template_name): | |||
There was a problem hiding this comment.
Call to this is still passing third parameter.
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
- Coverage 98.24% 98.22% -0.03%
==========================================
Files 195 195
Lines 9540 9540
==========================================
- Hits 9373 9371 -2
- Misses 133 134 +1
- Partials 34 35 +1
Continue to review full report at Codecov.
|
objectiser
approved these changes
Sep 2, 2019
bookmoons
pushed a commit
to bookmoons/jaeger
that referenced
this pull request
Sep 10, 2019
…cing#1769) * Add elasticsearch version configuration to rollover script Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Remove version parameter from call Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1753
Signed-off-by: Pavol Loffay ploffay@redhat.com