Allow token propagation if token type is not specified #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
rubenvp8510
force-pushed
the
token-propagation-no-schema
branch
2 times, most recently
from
2e59817
to
7379625
Compare
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
==========================================
+ Coverage 98.49% 98.49% +<.01%
==========================================
Files 193 193
Lines 9284 9286 +2
==========================================
+ Hits 9144 9146 +2
Misses 111 111
Partials 29 29
Continue to review full report at Codecov.
|
rubenvp8510
force-pushed
the
token-propagation-no-schema
branch
from
7379625
to
b4a7714
Compare
|
lgtm but I don't think we want all those log statements |
|
@yurishkuro ok I can remove it |
rubenvp8510
force-pushed
the
token-propagation-no-schema
branch
from
b4a7714
to
9f4ba33
Compare
|
I remove one, and change to debug others. Is that ok? or do you prefer to get rid of it? |
yurishkuro
reviewed
Jul 25, 2019
| if authHeaderValue != "" { | ||
| headerValue := strings.Split(authHeaderValue, " ") | ||
| token := "" | ||
| if len(headerValue) == 2 { | ||
| // Make sure we only capture bearer token , not other types like Basic auth. | ||
| if headerValue[0] == "Bearer" { | ||
| token = headerValue[1] | ||
| } else { | ||
| logger.Debug("Unsupported type of token " + headerValue[0] + " skipping token propagation") |
| @@ -26,21 +27,30 @@ import ( | |||
| func bearerTokenPropagationHandler(logger *zap.Logger, h http.Handler) http.Handler { | |||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| ctx := r.Context() | |||
| logger.Info("Propagating bearer token") | |||
| @@ -26,21 +27,30 @@ import ( | |||
| func bearerTokenPropagationHandler(logger *zap.Logger, h http.Handler) http.Handler { | |||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| ctx := r.Context() | |||
| logger.Info("Propagating bearer token") | |||
| log.Print(r) | |||
There was a problem hiding this comment.
Ups it was not my intend to have this here.
| if authHeaderValue == "" { | ||
| authHeaderValue = r.Header.Get("X-Forwarded-Access-Token") | ||
| } | ||
| logger.Info("Token: " + authHeaderValue) |
rubenvp8510
force-pushed
the
token-propagation-no-schema
branch
from
9f4ba33
to
ed35e2e
Compare
|
Done, logs removed, except warning log for unparseable header. |
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
rubenvp8510
force-pushed
the
token-propagation-no-schema
branch
from
ed35e2e
to
3852889
Compare
yurishkuro
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Authorization: <type> <token>, they put the token in the formAuthorization: <token>and assumed that the token there is a bearer token.Short description of the changes