Move jaeger code base to go modules #1546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step 1 in moving to modules Signed-off-by: Edward Muller <freeformz@gmail.com>
Adjust instructions for people/travis on how to use the code base now that it's using modules. Signed-off-by: Edward Muller <freeformz@gmail.com>
Replaces `dep ensure -vendor-only` with it's spiritual successor: `go mod vendor` Signed-off-by: Edward Muller <freeformz@gmail.com>
As per https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module & https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md Signed-off-by: Edward Muller <freeformz@gmail.com>
md-to-godoc relies on this version and newer versions of blackfriday are incompatible. Signed-off-by: Edward Muller <freeformz@gmail.com>
I don't see a reason to use vendor (in this case) with go modules. Signed-off-by: Edward Muller <freeformz@gmail.com>
Signed-off-by: Edward Muller <freeformz@gmail.com>
Signed-off-by: Edward Muller <freeformz@gmail.com>
Signed-off-by: Edward Muller <freeformz@gmail.com>
freeformz
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Downgrade github.com/hashicorp/go-hclog to v0.8.0 to match current Gopkg.toml. Slight upgrade to honnef.co/go/tools to match Gopkg.toml.
|
We're not ready to switch to go mod because there are users (including Uber) who import this repo as lib using dep, and dep won't be able to pick the correct versions of transitive dependencies. We could go to dual mode, similar to how in the past we supported both glide and dep simultaneously, for a period of time. If we do that, we'd need the CI to do a build with both tools. |
|
Do you know what time scale Uber has to move things that rely on jaeger to go modules? If they're all public I'd be happy to do the work to move them to go modules as well. |
|
I know the work on supporting modules has started, but don't know the ETA. I'd guess closer to the end of the year. It's internal to Uber. |
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2019
Which problem is this PR solving?
Move the jaeger code base to use Go Modules for dependency management.
Short description of the changes
Replace glide with go modules. Record tooling versions in
tools.go, adjust Makefile and other build tooling to use go modules.