Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore autogenerated files from import-order-cleanup #1445

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

annanay25
Copy link
Member

@annanay25 annanay25 commented Mar 26, 2019

Signed-off-by: Annanay annanay.a@media.net

Which problem is this PR solving?

  • Travis complains about unformatted proto generated files

Short description of the changes

  • Add list of proto generated files to ignored files in import-order-cleanup.

Signed-off-by: Annanay <annanay.a@media.net>
@annanay25
Copy link
Member Author

Seeing this issue in #1427

@annanay25
Copy link
Member Author

TestSaramaConsumerWrapper_start_Messages seems to have failed.

@annanay25
Copy link
Member Author

Actually make fmt will not touch any autogenerated files -

jaeger/Makefile

Lines 4 to 20 in 6bbe8dc

# all .go files that are not auto-generated and should be auto-formatted and linted.
ALL_SRC := $(shell find . -name '*.go' \
-not -name 'doc.go' \
-not -name '_*' \
-not -name '.*' \
-not -name 'gen_assets.go' \
-not -name 'mocks*' \
-not -name '*_test.go' \
-not -name 'model.pb.go' \
-not -name 'model_test.pb.go' \
-not -path './examples/*' \
-not -path './vendor/*' \
-not -path '*/mocks/*' \
-not -path '*/*-gen/*' \
-not -path '*/thrift-0.9.2/*' \
-type f | \
sort)

What we actually need is to remove the fmt check for autogenerated files.

Signed-off-by: Annanay <annanay.a@media.net>
@annanay25 annanay25 changed the title Add make fmt to travis PROTO_GEN_TEST Ignore autogenerated files from import-order-cleanup Mar 26, 2019
@yurishkuro yurishkuro merged commit fc48919 into jaegertracing:master Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #1445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1445   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         165     165           
  Lines        7539    7539           
======================================
  Hits         7539    7539

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbe8dc...addbaf3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants