Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OpenTelemetry SDK to v1.22.0 #5116

Closed
yurishkuro opened this issue Jan 18, 2024 · 2 comments · Fixed by #5137
Closed

Upgrade OpenTelemetry SDK to v1.22.0 #5116

yurishkuro opened this issue Jan 18, 2024 · 2 comments · Fixed by #5137
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

The dependabot upgrade is failing tests #5115.

  • Use gh cli to download it : gh pr checkout 5115
  • Reproduce
  • Find a fix for the issue
  • Create a branch from that PR and submit a new PR
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jan 18, 2024
@officialasishkumar
Copy link

I would like to work on this issue

@pash415
Copy link

pash415 commented Jan 18, 2024

Me too!

@chirag-ghosh chirag-ghosh mentioned this issue Jan 23, 2024
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Jan 24, 2024
@chirag-ghosh @dependabot
Upgrade OpenTelemetry SDK to v1.22.0 (#5137)
8c00cc1 
## Which problem is this PR solving?
- Fixes #5116 
- Replaces #5115 

## Description of the changes
- Upgrade OTel SDK to v1.22 (dependabot)
- Upgrade semconv version to v1.24 ([Reference
issue](open-telemetry/opentelemetry-go#2341)).
I tried using semconv v1.22 but it was still failing.
- Replace deprecated function `semconv.HTTPStatusCodeKey` with
`semconv.HTTPResponseStatusCodeKey`

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade OpenTelemetry SDK to v1.22.0 chirag-ghosh/jaeger
3 participants
@yurishkuro @officialasishkumar @pash415