Remove deprecated CLI flags

[yurishkuro]

We've accumulated a lot of deprecated flags, it would be good to remove them. Need to verify some of these, but I think all of them are past their expiration date.

We should not clean them in a single PR since they usually require code changes, better to do one PR per flag.

• admin flags Remove deprecated admin server flags #2752
• collector raw ports Remove deprecated collector flags #2751
• agent tags Remove deprecated --jaeger.tags CLI flag #2753
• queryPortWarning & queryHOSTPortWarning Remove deprecated Query Server flags #2772
• cassandra flags Remove deprecated cassandra flags #2789
• es.max-num-spans Remove deprecated es.max-num-spans #2482
• tls flags Remove deprecated TLS flags #2790

$ grep -rin '(deprecated' .
./cmd/flags/admin.go:39:	healthCheckHTTPPortWarning = "(deprecated, will be removed after 2020-03-15 or in release v1.19.0, whichever is later)"
./cmd/flags/admin.go:40:	adminHTTPPortWarning       = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)"
./cmd/collector/app/builder_flags.go:45:	collectorHTTPPortWarning       = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)"
./cmd/collector/app/builder_flags.go:46:	collectorGRPCPortWarning       = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)"
./cmd/collector/app/builder_flags.go:47:	collectorZipkinHTTPPortWarning = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)"
./cmd/agent/app/reporter/flags.go:51:		flags.String(AgentTagsDeprecated, "", "(deprecated) see --"+agentTags)
./cmd/query/app/flags.go:42:	queryPortWarning        = "(deprecated, will be removed after 2020-08-31 or in release v1.20.0, whichever is later)"
./cmd/query/app/flags.go:43:	queryHOSTPortWarning    = "(deprecated, will be removed after 2020-12-31 or in release v1.21.0, whichever is later)"
./plugin/storage/cassandra/options.go:237:		"(deprecated) Jaeger will automatically detect the version of the dependencies table")
./plugin/storage/cassandra/options.go:241:		"(deprecated) Enable (or disable) host key verification. Use "+nsConfig.namespace+".tls.skip-host-verify instead")
./plugin/storage/es/options.go:186:		"(deprecated, will be removed in release v1.21.0. Please use "+nsConfig.namespace+".max-doc-count). "+
./pkg/config/tlscfg/flags.go:54:		flags.Bool(c.Prefix+tlsEnabledOld, false, "(deprecated) see --"+c.Prefix+tlsEnabled)
./pkg/config/tlscfg/flags.go:69:		flags.Bool(c.Prefix+tlsEnabledOld, false, "(deprecated) see --"+c.Prefix+tlsEnabled)
./pkg/config/tlscfg/flags.go:74:	flags.String(c.Prefix+tlsClientCAOld, "", "(deprecated) see --"+c.Prefix+tlsClientCA)

[pradeepnnv]

I'd like to submit a PR for removing healthCheckHTTPPortWarning.

[BernardTolosajr]

I'd like to work on removing adminHTTPPortWarning. Thanks

[LostLaser]

I can pick up collectorHTTPPortWarning, collectorGRPCPortWarning, and collectorZipkinHTTPPortWarning

[yurishkuro]

@rjs211 I just noticed that you had to juggle various permutations of the old settings, but according to the deprecation timestamp, both -query.port and -query.host-port are due to be removed. Since we're doing this clean-up for the next release anyway, would you like to remove them as part of this ticket, and possibly simplify the logic (as well as the CHANGELOG)?

[rjs211]

@yurishkuro Sure. Will do this first. I'll move to #2249 after this.

[yurishkuro]

Thanks everyone, this was a fun collective effort.