Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test TestClientMetricsReporter_Expire #2145

Closed
yurishkuro opened this issue Mar 31, 2020 · 1 comment
Closed

Fix flaky test TestClientMetricsReporter_Expire #2145

yurishkuro opened this issue Mar 31, 2020 · 1 comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member 

--- FAIL: TestClientMetricsReporter_Expire (0.02s)
    --- FAIL: TestClientMetricsReporter_Expire/iter0:gauge=1,log=new_client (0.02s)
        client_metrics_test.go:268: 
            	Error Trace:	client_metrics_test.go:268
            	Error:      	Not equal: 
            	            	expected: int(1)
            	            	actual  : int64(0)
            	Test:       	TestClientMetricsReporter_Expire/iter0:gauge=1,log=new_client
    --- PASS: TestClientMetricsReporter_Expire/iter1:gauge=0,log=freeing_stats (0.00s)
FAIL	github.com/jaegertracing/jaeger/cmd/agent/app/reporter	0.064s
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Mar 31, 2020
@ghost ghost added the needs-triage label Mar 31, 2020
@pavolloffay
Copy link
Member

It might be a duplicate of #2108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurishkuro @pavolloffay