Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test TestClientMetricsReporter_Expire #2108

Closed
pavolloffay opened this issue Mar 2, 2020 · 1 comment · Fixed by #2170
Closed

Fix flaky test TestClientMetricsReporter_Expire #2108

pavolloffay opened this issue Mar 2, 2020 · 1 comment · Fixed by #2170
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Mar 2, 2020 •
edited by yurishkuro
Loading

It seems to be touched in #2010

--- FAIL: TestClientMetricsReporter_Expire (0.01s)
    --- FAIL: TestClientMetricsReporter_Expire/iter0:gauge=1,log=new_client (0.01s)
        client_metrics_test.go:268: 
            	Error Trace:	client_metrics_test.go:268
            	Error:      	Not equal: 
            	            	expected: int(1)
            	            	actual  : int64(0)
            	Test:       	TestClientMetricsReporter_Expire/iter0:gauge=1,log=new_client
FAIL	github.com/jaegertracing/jaeger/cmd/agent/app/reporter	0.064s
@ghost ghost added the needs-triage label Mar 2, 2020
@yurishkuro
Copy link
Member

I tried to fix it last week, but the fix didn't take, apparently.

@pavolloffay pavolloffay mentioned this issue Mar 31, 2020
Closed
@yurishkuro yurishkuro changed the title Flaky test TestClientMetricsReporter_Expire/iter0:gauge=1,log=new_client Fix flaky test TestClientMetricsReporter_Expire Mar 31, 2020
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Mar 31, 2020
@pavolloffay pavolloffay mentioned this issue Apr 6, 2020
Closed
@yurishkuro yurishkuro mentioned this issue Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
2 participants
@yurishkuro @pavolloffay