Skip to content

Commit

Permalink
Change the default value of the flag '--ingester.deadlockInterval' to…
Browse files Browse the repository at this point in the history
… 0 (#1868)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
  • Loading branch information
jpkrohling authored and yurishkuro committed Oct 19, 2019
1 parent d77a9b5 commit fe73936
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Changes by Version

##### Breaking Changes

* The default value for the Ingester's flag `ingester.deadlockInterval` has been changed to `0`. With the new default, the ingester won't `panic` if there are no messages for the last minute. To restore the previous behavior, set the flag's value to `1m`.

##### New Features

##### Bug fixes, Minor Improvements
Expand Down
2 changes: 1 addition & 1 deletion cmd/ingester/app/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const (
// DefaultEncoding is the default span encoding
DefaultEncoding = kafka.EncodingProto
// DefaultDeadlockInterval is the default deadlock interval
DefaultDeadlockInterval = 1 * time.Minute
DefaultDeadlockInterval = time.Duration(0)
)

// Options stores the configuration options for the Ingester
Expand Down

0 comments on commit fe73936

Please sign in to comment.