Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: Yuri Shkuro <github@ysh.us>
  • Loading branch information
yurishkuro committed Oct 22, 2024
1 parent 2879553 commit f05b569
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions cmd/jaeger/internal/integration/e2e_integration.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"os"
"os/exec"
"path/filepath"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -187,11 +186,6 @@ func (s *E2EStorageIntegration) doHealthCheck(t *testing.T) bool {
t.Logf("HTTP response not OK: %v", string(body))
return false
}
// for backwards compatibility with other healthchecks
if !strings.HasSuffix(healthCheckEndpoint, "/status") {
t.Logf("OK HTTP from endpoint that is not healthcheckv2")
return true
}

var healthResponse struct {
Status string `json:"status"`
Expand All @@ -207,7 +201,7 @@ func (s *E2EStorageIntegration) doHealthCheck(t *testing.T) bool {
return false
}

// @nocommit: this is a temporary hack to introduce a delay
// @nocommit: this is a temporary hack to ensure reproducible failure
t.Logf("%s is ready, but let's sleep a bit", s.BinaryName)
time.Sleep(30*time.Second + 3*time.Second)

Expand Down

0 comments on commit f05b569

Please sign in to comment.