Enable Lint Rule: redefines-builtin-id (#5791)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Partial Fix for #5506

## Description of the changes
- Enabled redefines-builtin-id in revive linter. Replaced function name
which redefinition of the built-in function

## How was this change tested?
- make lint make test

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: ZXYxc <reisaruxxii@gmail.com>

.golangci.yml

@@ -211,9 +211,6 @@ linters-settings:
         # this is idiocy, promotes less readable code. Don't enable.
         - name: var-declaration
           disabled: true
-        # enable after cleanup
-        - name: redefines-builtin-id
-          disabled: true
         # "no nested structs are allowed" - don't enable, doesn't make sense
         - name: nested-structs
           disabled: true

cmd/agent/app/configmanager/grpc/manager_test.go

@@ -5,7 +5,6 @@ package grpc
 
 import (
 	"context"
-	"io"
 	"net"
 	"testing"
 
@@ -18,16 +17,12 @@ import (
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2"
 )
 
-func close(t *testing.T, c io.Closer) {
-	require.NoError(t, c.Close())
-}
-
 func TestSamplingManager_GetSamplingStrategy(t *testing.T) {
 	s, addr := initializeGRPCTestServer(t, func(s *grpc.Server) {
 		api_v2.RegisterSamplingManagerServer(s, &mockSamplingHandler{})
 	})
 	conn, err := grpc.NewClient(addr.String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
-	defer close(t, conn)
+	t.Cleanup(func() { require.NoError(t, conn.Close()) })
 	require.NoError(t, err)
 	defer s.GracefulStop()
 	manager := NewConfigManager(conn)
@@ -38,7 +33,7 @@ func TestSamplingManager_GetSamplingStrategy(t *testing.T) {
 
 func TestSamplingManager_GetSamplingStrategy_error(t *testing.T) {
 	conn, err := grpc.NewClient("foo", grpc.WithTransportCredentials(insecure.NewCredentials()))
-	defer close(t, conn)
+	t.Cleanup(func() { require.NoError(t, conn.Close()) })
 	require.NoError(t, err)
 	manager := NewConfigManager(conn)
 	resp, err := manager.GetSamplingStrategy(context.Background(), "any")

plugin/sampling/strategyprovider/static/provider.go

@@ -375,7 +375,7 @@ func deepCopy(s *api_v2.SamplingStrategyResponse) *api_v2.SamplingStrategyRespon
 	enc := gob.NewEncoder(&buf)
 	dec := gob.NewDecoder(&buf)
 	enc.Encode(*s)
-	var copy api_v2.SamplingStrategyResponse
-	dec.Decode(&copy)
-	return &copy
+	var copyValue api_v2.SamplingStrategyResponse
+	dec.Decode(&copyValue)
+	return &copyValue
 }