-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix batchProcessor to set correct span format flags (#4796)
## Which problem is this PR solving? Recently I've noticed that collector sends wrong tags "format" and "transport" in metric `jaeger_collector_spans_received_total`. Root cause: when batchProcessor was extended to be called from OTLP Receiver, it was given SpanOptions parameter that could specify a different span format OTLP, vs. always setting Proto. But the processor was still using hardcoded Proto format when invoking the next processor. ## How was this change tested? Added unit test ## Checklist - [ x ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ x ] I have signed all commits - [ - ] I have added unit tests for the new functionality (not needed) - [ x ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Alexander Kozlov <aleksandr.kozlov@workato.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <github@ysh.us>
- Loading branch information
1 parent
7cd109f
commit 6919fd7
Showing
2 changed files
with
64 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters