Skip to content

Commit

Permalink
Merge branch 'main' into otel-servers
Browse files Browse the repository at this point in the history
  • Loading branch information
mahadzaryab1 authored Oct 23, 2024
2 parents b4c8e83 + 37d1fc1 commit 573293b
Show file tree
Hide file tree
Showing 14 changed files with 234 additions and 221 deletions.
5 changes: 2 additions & 3 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ To become a maintainer you need to demonstrate the following:

A new maintainer must be proposed by an existing maintainer by sending a message to the
[jaeger-tracing@googlegroups.com](https://groups.google.com/forum/#!forum/jaeger-tracing)
mailing list containing the following information:
mailing list, or by opening an issue on GitHub, containing the following information:

* nominee's first and last name,
* nominee's email address and GitHub user name,
* nominee's first and last name and GitHub user name,
* an explanation of why the nominee should be a committer,
* a list of links to non-trivial pull requests (top 10) authored by the nominee.

Expand Down
2 changes: 0 additions & 2 deletions cmd/jaeger/internal/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"go.opentelemetry.io/collector/exporter/otlpexporter"
"go.opentelemetry.io/collector/exporter/otlphttpexporter"
"go.opentelemetry.io/collector/extension"
"go.opentelemetry.io/collector/extension/ballastextension"
"go.opentelemetry.io/collector/extension/zpagesextension"
"go.opentelemetry.io/collector/otelcol"
"go.opentelemetry.io/collector/processor"
Expand Down Expand Up @@ -63,7 +62,6 @@ func (b builders) build() (otelcol.Factories, error) {

factories.Extensions, err = b.extension(
// standard
ballastextension.NewFactory(),
zpagesextension.NewFactory(),
healthcheckv2extension.NewFactory(),
// add-ons
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func TestExporter(t *testing.T) {
err := config.Validate()
require.NoError(t, err)

tracesExporter, err := exporterFactory.CreateTracesExporter(ctx, exporter.Settings{
tracesExporter, err := exporterFactory.CreateTraces(ctx, exporter.Settings{
ID: ID,
TelemetrySettings: telemetrySettings,
BuildInfo: component.NewDefaultBuildInfo(),
Expand Down Expand Up @@ -172,7 +172,7 @@ func makeStorageExtension(t *testing.T, memstoreName string) component.Host {
MeterProvider: noopmetric.NewMeterProvider(),
}
extensionFactory := jaegerstorage.NewFactory()
storageExtension, err := extensionFactory.CreateExtension(
storageExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
TelemetrySettings: telemetrySettings,
Expand Down
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/exporters/storageexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func createDefaultConfig() component.Config {
func createTracesExporter(ctx context.Context, set exporter.Settings, config component.Config) (exporter.Traces, error) {
cfg := config.(*Config)
ex := newExporter(cfg, set.TelemetrySettings)
return exporterhelper.NewTracesExporter(ctx, set, cfg,
return exporterhelper.NewTraces(ctx, set, cfg,
ex.pushTraces,
exporterhelper.WithCapabilities(consumer.Capabilities{MutatesData: false}),
// Disable Timeout/RetryOnFailure
Expand Down
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/extension/expvar/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func TestCreateDefaultConfig(t *testing.T) {
func TestCreateExtension(t *testing.T) {
cfg := createDefaultConfig().(*Config)
f := NewFactory()
r, err := f.CreateExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
r, err := f.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
require.NoError(t, err)
assert.NotNil(t, r)
}
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ func noopTelemetrySettings() component.TelemetrySettings {
func makeStorageExtenion(t *testing.T, config *Config) component.Component {
extensionFactory := NewFactory()
ctx := context.Background()
ext, err := extensionFactory.CreateExtension(ctx,
ext, err := extensionFactory.Create(ctx,
extension.Settings{
ID: ID,
TelemetrySettings: noopTelemetrySettings(),
Expand Down
14 changes: 7 additions & 7 deletions cmd/jaeger/internal/extension/remotesampling/extension_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func makeStorageExtension(t *testing.T, memstoreName string) component.Host {
MeterProvider: noopmetric.NewMeterProvider(),
}
extensionFactory := jaegerstorage.NewFactory()
storageExtension, err := extensionFactory.CreateExtension(
storageExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
TelemetrySettings: telemetrySettings,
Expand All @@ -67,7 +67,7 @@ func makeStorageExtension(t *testing.T, memstoreName string) component.Host {

func makeRemoteSamplingExtension(t *testing.T, cfg component.Config) component.Host {
extensionFactory := NewFactory()
samplingExtension, err := extensionFactory.CreateExtension(
samplingExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
TelemetrySettings: component.TelemetrySettings{
Expand Down Expand Up @@ -95,7 +95,7 @@ func TestStartFileBasedProvider(t *testing.T) {
cfg.GRPC = nil
require.NoError(t, cfg.Validate())

ext, err := factory.CreateExtension(context.Background(), extension.Settings{
ext, err := factory.Create(context.Background(), extension.Settings{
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
}, cfg)
require.NoError(t, err)
Expand All @@ -115,7 +115,7 @@ func TestStartHTTP(t *testing.T) {
cfg.GRPC = nil
require.NoError(t, cfg.Validate())

ext, err := factory.CreateExtension(context.Background(), extension.Settings{
ext, err := factory.Create(context.Background(), extension.Settings{
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
}, cfg)
require.NoError(t, err)
Expand Down Expand Up @@ -155,7 +155,7 @@ func TestStartGRPC(t *testing.T) {
}
require.NoError(t, cfg.Validate())

ext, err := factory.CreateExtension(context.Background(), extension.Settings{
ext, err := factory.Create(context.Background(), extension.Settings{
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
}, cfg)
require.NoError(t, err)
Expand Down Expand Up @@ -183,7 +183,7 @@ func TestStartAdaptiveProvider(t *testing.T) {
cfg.GRPC = nil
require.NoError(t, cfg.Validate())

ext, err := factory.CreateExtension(context.Background(), extension.Settings{
ext, err := factory.Create(context.Background(), extension.Settings{
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
}, cfg)
require.NoError(t, err)
Expand Down Expand Up @@ -249,7 +249,7 @@ func TestGetAdaptiveSamplingComponentsErrors(t *testing.T) {
func TestDependencies(t *testing.T) {
factory := NewFactory()
cfg := factory.CreateDefaultConfig().(*Config)
ext, err := factory.CreateExtension(context.Background(), extension.Settings{
ext, err := factory.Create(context.Background(), extension.Settings{
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
}, cfg)
require.NoError(t, err)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func TestCreateDefaultConfig(t *testing.T) {
func TestCreateExtension(t *testing.T) {
cfg := createDefaultConfig().(*Config)
f := NewFactory()
r, err := f.CreateExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
r, err := f.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
require.NoError(t, err)
assert.NotNil(t, r)
}
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/integration/span_writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func createSpanWriter(logger *zap.Logger, port int) (*spanWriter, error) {
set := exportertest.NewNopSettings()
set.Logger = logger

exporter, err := factory.CreateTracesExporter(context.Background(), set, cfg)
exporter, err := factory.CreateTraces(context.Background(), set, cfg)
if err != nil {
return nil, err
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func TestCreateDefaultConfig(t *testing.T) {
func TestCreateExtension(t *testing.T) {
cfg := createDefaultConfig().(*Config)
f := NewFactory()
r, err := f.CreateExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
r, err := f.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
require.NoError(t, err)
assert.NotNil(t, r)
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func makeStorageExtension(t *testing.T, memstoreName string) component.Host {
MeterProvider: noopmetric.NewMeterProvider(),
}
extensionFactory := jaegerstorage.NewFactory()
storageExtension, err := extensionFactory.CreateExtension(
storageExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
TelemetrySettings: telemetrySettings,
Expand All @@ -61,7 +61,7 @@ var _ component.Config = (*Config)(nil)

func makeRemoteSamplingExtension(t *testing.T, cfg component.Config) component.Host {
extensionFactory := remotesampling.NewFactory()
samplingExtension, err := extensionFactory.CreateExtension(
samplingExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
TelemetrySettings: component.TelemetrySettings{
Expand Down
136 changes: 70 additions & 66 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -44,37 +44,38 @@ require (
github.com/stretchr/testify v1.9.0
github.com/uber/jaeger-client-go v2.30.0+incompatible
github.com/xdg-go/scram v1.1.2
go.opentelemetry.io/collector/component v0.111.0
go.opentelemetry.io/collector/component/componentstatus v0.111.0
go.opentelemetry.io/collector/config/configauth v0.111.0
go.opentelemetry.io/collector/config/configgrpc v0.111.0
go.opentelemetry.io/collector/config/confighttp v0.111.0
go.opentelemetry.io/collector/config/configretry v1.17.0
go.opentelemetry.io/collector/config/configtls v1.17.0
go.opentelemetry.io/collector/confmap v1.17.0
go.opentelemetry.io/collector/confmap/provider/envprovider v1.17.0
go.opentelemetry.io/collector/confmap/provider/fileprovider v1.17.0
go.opentelemetry.io/collector/confmap/provider/httpprovider v1.17.0
go.opentelemetry.io/collector/confmap/provider/httpsprovider v1.17.0
go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.17.0
go.opentelemetry.io/collector/connector v0.111.0
go.opentelemetry.io/collector/connector/forwardconnector v0.111.0
go.opentelemetry.io/collector/consumer v0.111.0
go.opentelemetry.io/collector/consumer/consumertest v0.111.0
go.opentelemetry.io/collector/exporter v0.111.0
go.opentelemetry.io/collector/exporter/otlpexporter v0.111.0
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.111.0
go.opentelemetry.io/collector/extension v0.111.0
go.opentelemetry.io/collector/extension/ballastextension v0.108.1
go.opentelemetry.io/collector/extension/zpagesextension v0.111.0
go.opentelemetry.io/collector/otelcol v0.111.0
go.opentelemetry.io/collector/pdata v1.17.0
go.opentelemetry.io/collector/pipeline v0.111.0
go.opentelemetry.io/collector/processor v0.111.0
go.opentelemetry.io/collector/processor/batchprocessor v0.111.0
go.opentelemetry.io/collector/processor/memorylimiterprocessor v0.111.0
go.opentelemetry.io/collector/receiver v0.111.0
go.opentelemetry.io/collector/receiver/otlpreceiver v0.111.0
go.opentelemetry.io/collector/component v0.112.0
go.opentelemetry.io/collector/component/componentstatus v0.112.0
go.opentelemetry.io/collector/config/configauth v0.112.0
go.opentelemetry.io/collector/config/configgrpc v0.112.0
go.opentelemetry.io/collector/config/confighttp v0.112.0
go.opentelemetry.io/collector/config/configretry v1.18.0
go.opentelemetry.io/collector/config/configtls v1.18.0
go.opentelemetry.io/collector/confmap v1.18.0
go.opentelemetry.io/collector/confmap/provider/envprovider v1.18.0
go.opentelemetry.io/collector/confmap/provider/fileprovider v1.18.0
go.opentelemetry.io/collector/confmap/provider/httpprovider v1.18.0
go.opentelemetry.io/collector/confmap/provider/httpsprovider v1.18.0
go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.18.0
go.opentelemetry.io/collector/connector v0.112.0
go.opentelemetry.io/collector/connector/forwardconnector v0.112.0
go.opentelemetry.io/collector/consumer v0.112.0
go.opentelemetry.io/collector/consumer/consumertest v0.112.0
go.opentelemetry.io/collector/exporter v0.112.0
go.opentelemetry.io/collector/exporter/exportertest v0.112.0
go.opentelemetry.io/collector/exporter/otlpexporter v0.112.0
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.112.0
go.opentelemetry.io/collector/extension v0.112.0
go.opentelemetry.io/collector/extension/zpagesextension v0.112.0
go.opentelemetry.io/collector/otelcol v0.112.0
go.opentelemetry.io/collector/pdata v1.18.0
go.opentelemetry.io/collector/pipeline v0.112.0
go.opentelemetry.io/collector/processor v0.112.0
go.opentelemetry.io/collector/processor/batchprocessor v0.112.0
go.opentelemetry.io/collector/processor/memorylimiterprocessor v0.112.0
go.opentelemetry.io/collector/processor/processortest v0.112.0
go.opentelemetry.io/collector/receiver v0.112.0
go.opentelemetry.io/collector/receiver/otlpreceiver v0.112.0
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.56.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.56.0
go.opentelemetry.io/contrib/samplers/jaegerremote v0.25.0
Expand Down Expand Up @@ -103,6 +104,12 @@ require (
github.com/antchfx/xpath v1.3.1 // indirect
github.com/ebitengine/purego v0.8.0 // indirect
github.com/expr-lang/expr v1.16.9 // indirect
go.opentelemetry.io/collector/connector/connectortest v0.112.0 // indirect
go.opentelemetry.io/collector/consumer/consumererror v0.112.0 // indirect
go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/internal/memorylimiter v0.112.0 // indirect
go.opentelemetry.io/collector/pipeline/pipelineprofiles v0.112.0 // indirect
)

require (
Expand All @@ -126,7 +133,7 @@ require (
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.2.6 // indirect
github.com/go-viper/mapstructure/v2 v2.1.0 // indirect
github.com/go-viper/mapstructure/v2 v2.2.1 // indirect
github.com/gobwas/glob v0.2.3 // indirect
github.com/goccy/go-json v0.10.3 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
Expand Down Expand Up @@ -154,7 +161,7 @@ require (
github.com/jonboulle/clockwork v0.4.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.17.10 // indirect
github.com/klauspost/compress v1.17.11 // indirect
github.com/knadh/koanf/maps v0.1.1 // indirect
github.com/knadh/koanf/providers/confmap v0.1.0 // indirect
github.com/knadh/koanf/v2 v2.1.1 // indirect
Expand Down Expand Up @@ -215,40 +222,37 @@ require (
github.com/xdg-go/stringprep v1.0.4 // indirect
github.com/yusufpapurcu/wmi v1.2.4 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/collector v0.111.0 // indirect
go.opentelemetry.io/collector/client v1.17.0 // indirect
go.opentelemetry.io/collector/component/componentprofiles v0.111.0 // indirect
go.opentelemetry.io/collector/config/configcompression v1.17.0 // indirect
go.opentelemetry.io/collector/config/confignet v1.17.0
go.opentelemetry.io/collector/config/configopaque v1.17.0
go.opentelemetry.io/collector/config/configtelemetry v0.111.0
go.opentelemetry.io/collector/config/internal v0.111.0 // indirect
go.opentelemetry.io/collector/connector/connectorprofiles v0.111.0 // indirect
go.opentelemetry.io/collector/consumer/consumerprofiles v0.111.0 // indirect
go.opentelemetry.io/collector/exporter/debugexporter v0.111.0
go.opentelemetry.io/collector/exporter/exporterprofiles v0.111.0 // indirect
go.opentelemetry.io/collector/extension/auth v0.111.0 // indirect
go.opentelemetry.io/collector/extension/experimental/storage v0.111.0 // indirect
go.opentelemetry.io/collector/extension/extensioncapabilities v0.111.0
go.opentelemetry.io/collector/featuregate v1.17.0 // indirect
go.opentelemetry.io/collector/internal/globalgates v0.111.0 // indirect
go.opentelemetry.io/collector/internal/globalsignal v0.111.0 // indirect
go.opentelemetry.io/collector/pdata/pprofile v0.111.0 // indirect
go.opentelemetry.io/collector/pdata/testdata v0.111.0 // indirect
go.opentelemetry.io/collector/processor/processorprofiles v0.111.0 // indirect
go.opentelemetry.io/collector/receiver/receiverprofiles v0.111.0 // indirect
go.opentelemetry.io/collector/semconv v0.111.0 // indirect
go.opentelemetry.io/collector/service v0.111.0 // indirect
go.opentelemetry.io/collector v0.112.0 // indirect
go.opentelemetry.io/collector/client v1.18.0 // indirect
go.opentelemetry.io/collector/config/configcompression v1.18.0 // indirect
go.opentelemetry.io/collector/config/confignet v1.18.0
go.opentelemetry.io/collector/config/configopaque v1.18.0
go.opentelemetry.io/collector/config/configtelemetry v0.112.0
go.opentelemetry.io/collector/config/internal v0.112.0 // indirect
go.opentelemetry.io/collector/connector/connectorprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/consumer/consumerprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/exporter/debugexporter v0.112.0
go.opentelemetry.io/collector/exporter/exporterprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/extension/auth v0.112.0 // indirect
go.opentelemetry.io/collector/extension/experimental/storage v0.112.0 // indirect
go.opentelemetry.io/collector/extension/extensioncapabilities v0.112.0
go.opentelemetry.io/collector/featuregate v1.18.0 // indirect
go.opentelemetry.io/collector/pdata/pprofile v0.112.0 // indirect
go.opentelemetry.io/collector/pdata/testdata v0.112.0 // indirect
go.opentelemetry.io/collector/processor/processorprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/receiver/receiverprofiles v0.112.0 // indirect
go.opentelemetry.io/collector/semconv v0.112.0 // indirect
go.opentelemetry.io/collector/service v0.112.0 // indirect
go.opentelemetry.io/contrib/config v0.10.0 // indirect
go.opentelemetry.io/contrib/propagators/b3 v1.30.0 // indirect
go.opentelemetry.io/contrib/zpages v0.55.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.6.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.30.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.30.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutlog v0.6.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.30.0 // indirect
go.opentelemetry.io/otel/log v0.6.0 // indirect
go.opentelemetry.io/otel/sdk/log v0.6.0 // indirect
go.opentelemetry.io/contrib/propagators/b3 v1.31.0 // indirect
go.opentelemetry.io/contrib/zpages v0.56.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.7.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.31.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutlog v0.7.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.31.0 // indirect
go.opentelemetry.io/otel/log v0.7.0 // indirect
go.opentelemetry.io/otel/sdk/log v0.7.0 // indirect
go.opentelemetry.io/proto/otlp v1.3.1 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
Expand Down
Loading

0 comments on commit 573293b

Please sign in to comment.