-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtualized scrolling for trace detail view #68
Commits on Aug 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fe35bbd - Browse repository at this point
Copy the full SHA fe35bbdView commit details -
WIP commit for refactoring trace detail view
TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` SpanGraph - Fix #49 - Span position in graph doesn not match its position in the detail - Ticks in span graph made to match trace detail (in number and formatting) - Span graph refactored to trim down files and DOM elements TracePageHeader - `trace` prop removed - Added props for various title values instead of deriving them from `trace` Trace Detail - Several components split out into separate files - `transformTrace` to use alread span tree to determine span depth Span Detail - Fix uber/jaeger #326: extraneous scrollbars in trace views - Fix: Some tags were not being rendered due to clashing keys (observed in a log message) - Tall content scrolls via entire table instead of single table cell - Horizontal scrolling for wide content (e.g. long log values) - Full width of the header is clickable for tags, process, and logs headers (instead of header text, only) - Service and endpoint are shown on mouseover anywhere in span bar row Misc - Several TraceTimelineViewer / utils removed - `TreeNode` `.walk()` method can now be used to calculate the depth, avoiding use of less efficient `.getPath()` - Removed several `console.error` warnings caused by React key issues
Configuration menu - View commit details
-
Copy full SHA for acbfdee - Browse repository at this point
Copy the full SHA acbfdeeView commit details
Commits on Aug 14, 2017
-
WIP commit for refactoring trace detail view
TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` Span Bar / Detail - Label on span bars no longer off-screen - Clip or hide span bars when zoomed in (insted of flush left) - Add shadow to left / right boundary when span bar view is clipped - Darkened span name column to differentiate from span bar section - Span detail left column color coded by service - Clicking span detail left column collapses detail - Clicking anywhere left of parent span name toggles children visibility
Configuration menu - View commit details
-
Copy full SHA for 4fa5c8a - Browse repository at this point
Copy the full SHA 4fa5c8aView commit details
Commits on Aug 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 93a6fb7 - Browse repository at this point
Copy the full SHA 93a6fb7View commit details
Commits on Aug 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b8945ab - Browse repository at this point
Copy the full SHA b8945abView commit details -
WIP refactor trace, yarn upgrade
Sub-page scrolling used for trace detail (TODO: revert this). This lays the ground work for using react-virtualized, but unfortunately has major perf issues, hence the TODO: revert. yarn upgrade --latest. Notable changes: - Removed react-sticky - react-router v4 - react-vis CSS needed to be included via a sym-link Misc tweaks: - Styling adjusted on trace mini-map - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name
Configuration menu - View commit details
-
Copy full SHA for 401b083 - Browse repository at this point
Copy the full SHA 401b083View commit details -
Configuration menu - View commit details
-
Copy full SHA for c34bbd3 - Browse repository at this point
Copy the full SHA c34bbd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c041353 - Browse repository at this point
Copy the full SHA c041353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f54454 - Browse repository at this point
Copy the full SHA 9f54454View commit details -
Configuration menu - View commit details
-
Copy full SHA for c657cf1 - Browse repository at this point
Copy the full SHA c657cf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2226744 - Browse repository at this point
Copy the full SHA 2226744View commit details -
Configuration menu - View commit details
-
Copy full SHA for f555e8b - Browse repository at this point
Copy the full SHA f555e8bView commit details
Commits on Aug 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for bef7f5b - Browse repository at this point
Copy the full SHA bef7f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8101efd - Browse repository at this point
Copy the full SHA 8101efdView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa6f016 - Browse repository at this point
Copy the full SHA fa6f016View commit details -
Fix unreleased regression - ellipsis on span name
Add back the styling that adds an ellipsis to truncated span name text.
Configuration menu - View commit details
-
Copy full SHA for 3797f5b - Browse repository at this point
Copy the full SHA 3797f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fd43f5 - Browse repository at this point
Copy the full SHA 0fd43f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 542c1ba - Browse repository at this point
Copy the full SHA 542c1baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42736e0 - Browse repository at this point
Copy the full SHA 42736e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d16097b - Browse repository at this point
Copy the full SHA d16097bView commit details
Commits on Aug 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 83b28d5 - Browse repository at this point
Copy the full SHA 83b28d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdd6d7e - Browse repository at this point
Copy the full SHA bdd6d7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7204684 - Browse repository at this point
Copy the full SHA 7204684View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bdf8b6 - Browse repository at this point
Copy the full SHA 9bdf8b6View commit details -
Merge branch 'refactor-trace-detail-selectors' into milestone1/issue-…
…60-react-virtualized
Configuration menu - View commit details
-
Copy full SHA for da7bbb2 - Browse repository at this point
Copy the full SHA da7bbb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 762b1b1 - Browse repository at this point
Copy the full SHA 762b1b1View commit details -
WIP react-virtualized layout progress
Outstanding: - Window scroller used https://bvaughn.github.io/react-virtualized/#/components/WindowScroller - Expanding span details - Collapsing / expanding children
Configuration menu - View commit details
-
Copy full SHA for 0ed6fde - Browse repository at this point
Copy the full SHA 0ed6fdeView commit details
Commits on Aug 23, 2017
-
WIP react-virtualized layout progress
Switching to use a props oriented ui state management for span details. This is necessary because the virtualized scroller removes and adds span details as it scrolls. The span detail components cannot retain their own state (e.g. tags table is expanded / collapsed, etc.) because they are not long-lived.
Configuration menu - View commit details
-
Copy full SHA for 284c816 - Browse repository at this point
Copy the full SHA 284c816View commit details
Commits on Aug 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0113985 - Browse repository at this point
Copy the full SHA 0113985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c7f896 - Browse repository at this point
Copy the full SHA 5c7f896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 650c60b - Browse repository at this point
Copy the full SHA 650c60bView commit details
Commits on Aug 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d1fd592 - Browse repository at this point
Copy the full SHA d1fd592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 831aa9c - Browse repository at this point
Copy the full SHA 831aa9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eeec40 - Browse repository at this point
Copy the full SHA 3eeec40View commit details -
Configuration menu - View commit details
-
Copy full SHA for c749135 - Browse repository at this point
Copy the full SHA c749135View commit details
Commits on Aug 29, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 11fa23e - Browse repository at this point
Copy the full SHA 11fa23eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c88e723 - Browse repository at this point
Copy the full SHA c88e723View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8dd6b8 - Browse repository at this point
Copy the full SHA f8dd6b8View commit details
Commits on Aug 30, 2017
-
Configuration menu - View commit details
-
Copy full SHA for cd45e62 - Browse repository at this point
Copy the full SHA cd45e62View commit details -
Configuration menu - View commit details
-
Copy full SHA for f45d360 - Browse repository at this point
Copy the full SHA f45d360View commit details
Commits on Aug 31, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ff2ae49 - Browse repository at this point
Copy the full SHA ff2ae49View commit details
Commits on Sep 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3c8057e - Browse repository at this point
Copy the full SHA 3c8057eView commit details
Commits on Sep 5, 2017
-
PR feedback - JSDoc, move trace transform
- JSDoc tweaks - documentation.js can infer types automatically - Move trace transform - Move trace tranform out of src/components/TracePage/TraceTimelineViewer/transforms and into src/model/transform-trace-data.js - Apply trace transform to data from HTTP response so the trace data stored in the state is always the enriched form
Configuration menu - View commit details
-
Copy full SHA for 6059fed - Browse repository at this point
Copy the full SHA 6059fedView commit details
Commits on Sep 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ff779db - Browse repository at this point
Copy the full SHA ff779dbView commit details