Add memoizaion for getConfig #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
th3M1ke
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 94.23% 94.26% +0.03%
==========================================
Files 228 228
Lines 5930 5931 +1
Branches 1492 1492
==========================================
+ Hits 5588 5591 +3
+ Misses 304 302 -2
Partials 38 38
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 15, 2021
| @@ -59,6 +59,7 @@ describe('getConfig()', () => { | |||
| let getJaegerUiConfig; | |||
|
|
|||
| beforeEach(() => { | |||
| getConfig.apply({}, []); | |||
There was a problem hiding this comment.
This is reset memoization cache
There was a problem hiding this comment.
thx. I wish they would've fixed that ticket by adding an explicit method like reset(), much better for readability.
|
I don't think #678 requires re-evaluation. As long as I can have a function stored in a config key, it should be fine. |
bobrik
approved these changes
Jan 15, 2021
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
getConfig()runShort description of the changes
getConfig()