-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ImmutableJS, refactor search selectors #48
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
81bd57c
Update prettier and wrap at 110 instead of 80
tiffon 75a014c
Remove ImmutableJS from reducers
tiffon 288d04a
Remove remaining ImmutableJS-oriented functionality
tiffon 717b162
Merge branch 'remove-immutablejs' into refactor-search-selectors
tiffon 42c0cb9
Refactor search page mapStateToProps
tiffon 32fcca0
Add flow-types and tests for model/search
tiffon 661359d
Use spread operator instead of Object.assign
tiffon 9a3a2f4
Misc inline comments
tiffon 5f042f0
Merge branch 'master' into refactor-search-selectors
tiffon f1f7343
misc PR feedback
tiffon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,9 +18,8 @@ | |
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
|
||
import jaegerReducers from './index'; | ||
import traceReducer from './trace'; | ||
|
||
it('jaegerReducers should contain the trace reducer', () => { | ||
expect(jaegerReducers.trace).toBe(traceReducer); | ||
}); | ||
export const MOST_RECENT = 'MOST_RECENT'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this file needs license info, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. Done. |
||
export const LONGEST_FIRST = 'LONGEST_FIRST'; | ||
export const SHORTEST_FIRST = 'SHORTEST_FIRST'; | ||
export const MOST_SPANS = 'MOST_SPANS'; | ||
export const LEAST_SPANS = 'LEAST_SPANS'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a common way of naming single lodash functions? Historically, this is generally meant for private variables.
Are we opposed to bring in the whole lib because of size? If so, I suppose we could do this style as long as we are consistent throughout the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saminzadeh I have mixed feelings about the name, myself, for the same reason. I went with
_values
becausevalues
would be an odd name for it as it's a function not a collection of values_values
has basically the same issue_values
is reminiscent of_.values
I noticed another project using the same approach, but I'm definitely open to alternatives... Maybe
valuesFn
? (orlodashValues
? Long names are a bother, though.)Yes, importing by function (also called cherry-picking, I think) yields smaller builds. Consistency in the project, in this respect, is a WIP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool, im open to the lodash function style of _values as an alias for _.values. It would be sweet if we could use this babel plugin but then we'd have to eject. https://github.com/lodash/babel-plugin-lodash