Updated Default Configuration for Deep Dependency Graph

[Wise-Wizard]

Problem

Resolves #600, which reported a concern related to [Feature] change the default layout selection for deep dependency graph view (view=ddg)

Changes

In order to resolve the mentioned issue, the following changes have been implemented:

• Implemented logic in the componentDidMount lifecycle method to check local storage for a previously selected density, setting it as the default if found.
• Modified the updateDensity method to save the selected density in local storage, ensuring persistence across sessions.
• Enhanced user experience by retaining and applying the last selected density even after page reloads.

Testing

The changes have been thoroughly tested to ensure their correctness and compatibility. The testing process included:

• Modifying the index.test.js, to also consider a default configuration from local storage, rather than only considering a fixed configuration for testing.

Checklist

To comply with the project's contribution guidelines, the following checklist items have been addressed:

• ✓ I have carefully read and followed the contributing guidelines.
• ✓ I have signed all commits.
• ✓ Unit tests for the new functionality have been added.
• ✓ Linting and testing steps have been successfully executed:
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test
    

[Wise-Wizard]

Please check the latest commit, I have made the necessary changes to the Tests.

[yurishkuro]

Thanks! LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2947a10) 96.54% compared to head (11fe261) 96.54%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2063   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         255      255           
  Lines        7616     7622    +6     
  Branches     1984     1985    +1     
=======================================
+ Hits         7353     7359    +6     
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Wise-Wizard]

All the checks except Lint has passed, Is there something that's remaining to be done from my end, or is it common and you shall kindly take a look and merge it manually?

[yurishkuro]

error message:

*** PLEASE RUN yarn prettier AND RESUBMIT ***

[Wise-Wizard]

Running yarn prettier, didn't resolve it. Please let me know of the steps I have to take to resolve this. It will be of great help. Does it have to do something with yarn version, because I am using v1.22.4 to locally setup my jaeger-ui repo.

[yurishkuro]

I ran yarn prettier and it applied the changes:

$ gst
	modified:   packages/jaeger-ui/src/components/DeepDependencies/Header/LayoutSettings/index.tsx

I just pushed them.

[Wise-Wizard]

Yes, even I did the same thing ran yarn prettier but it didn't seem to work for me locally :(

[Wise-Wizard]

Thanks a lot for your help, this PR really helped me grow and learn. Appreciate it. Can you please suggest some issues you would like me to take a look at next?

[yurishkuro]

I don't have particular suggestions, look for any help-wanted tickets that sound interesting to you.

[Wise-Wizard]

Sure, will take up the next one I find interesting:)