Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all uncontroversial icons from various icon sets to io5 #1771

Merged
merged 12 commits into from
Sep 19, 2023

Conversation

priyanshu-kun
Copy link
Contributor

@priyanshu-kun priyanshu-kun commented Sep 11, 2023

Signed-off-by: Priyanshu Sharma priyanshushrama709@gmail.com

Which problem is this PR solving?

Description of the changes

  • In this pull request, I have replaced all uncontroversial icons from various icon sets with the io5 icon set, enhancing the visual consistency and user experience across the platform.

Checklist

@yurishkuro
Copy link
Member

please make sure lint & unit tests succeed

priyanshu-kun added 2 commits September 13, 2023 20:25
…fix linting errors

Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
@yurishkuro
Copy link
Member

yurishkuro commented Sep 13, 2023

I think you need to regenerate the jest snapshots when changing icons, this is why the tests are failing. yarn test -u

Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
@priyanshu-kun
Copy link
Contributor Author

I think you need to regenerate the jest snapshots when changing icons, this is why the tests are failing. yarn test -u

Done!

Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
@priyanshu-kun priyanshu-kun mentioned this pull request Sep 15, 2023
4 tasks
…ceTimelineViewer/SpanDetail/KeyValuesTable.tsx file

Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
@anshgoyalevil
Copy link
Member

The rest of the changes looks good 🚀
Thanks @priyanshu-kun

Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure you have re-generated the snapshots.

priyanshu-kun added 2 commits September 17, 2023 19:13
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
priyanshu-kun and others added 3 commits September 17, 2023 20:51
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro merged commit 284075b into jaegertracing:main Sep 19, 2023
9 checks passed
@yurishkuro
Copy link
Member

🎉

@priyanshu-kun priyanshu-kun deleted the priyanshu-kun/#1723 branch September 19, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deps] Choose between antd/icons and react-icons
3 participants