Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add View Option for raw/unadjusted trace #153

Merged
merged 4 commits into from
Dec 24, 2017
Merged

Add View Option for raw/unadjusted trace #153

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
336a570
Add View Option for raw/unadjusted trace
Dec 23, 2017
575114d
Remove /
Dec 24, 2017
27c168a
Add missing prefixUrl adjustment
tiffon Dec 24, 2017
fa904d1
Fix failing unit test
tiffon Dec 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/TracePage/TracePageHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@ export default function TracePageHeader(props: TracePageHeaderProps) {
<Dropdown.Menu>
<Dropdown.Item>
<a rel="noopener noreferrer" target="_blank" href={`/api/traces/${traceID}`}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiffon I don't see this file in #151, it probably needs adjustment with the prefix as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurishkuro Yes, this needs the prefixUrl(...).

Also, is the trailing / in the raw version URL intentional?

/api/traces/${traceID}/?raw=true

Seems like the only difference should be the query string is appended?

/api/traces/${traceID}?raw=true

View Trace JSON
Trace JSON
</a>
</Dropdown.Item>
<Dropdown.Item>
<a rel="noopener noreferrer" target="_blank" href={`/api/traces/${traceID}/?raw=true`}>
Trace JSON (unadjusted)
</a>
</Dropdown.Item>
</Dropdown.Menu>
Expand Down