Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependencies tab configurable #122

Merged

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@@ -79,11 +83,11 @@ export default function TopNav(props: TopNavProps) {
<div className="ui input">
<TraceIDSearchInput />
</div>
{NAV_LINKS.map(({ key, to, text }) =>
{NAV_LINKS.map(({ key, to, text }) => (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

husky > npm run -s precommit (node v6.11.2)

does this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay I don't follow... can you elaborate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that this changes it done automatically via git hooks not by me

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.162% when pulling 62617dc on pavolloffay:make-deps-tab-configurable into df12ead on jaegertracing:master.

@yurishkuro
Copy link
Member

@pavolloffay could you please explain the objective / use case? It would also go to documentation of the new property.

@pavolloffay
Copy link
Member Author

The motivation behind this is that dependency screen in production deployment requires an external process. Some deployments don't use it. In other words it's optional.

@@ -79,11 +83,11 @@ export default function TopNav(props: TopNavProps) {
<div className="ui input">
<TraceIDSearchInput />
</div>
{NAV_LINKS.map(({ key, to, text }) =>
{NAV_LINKS.map(({ key, to, text }) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay I don't follow... can you elaborate?

key: 'search',
to: prefixUrl('/search'),
text: 'Search',
},
];

if (getConfig().depsMenuEnabled === true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be

if (getConfig().depsMenuEnabled) {

Or is there a reason to fail if truthy but not strictly true ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, updated

@@ -46,4 +46,5 @@ export default deepFreeze({
],
},
],
depsMenuEnabled: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be renamed to dependenciesMenuEnabled ?

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

PR updated

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.128% when pulling ba0cc1d on pavolloffay:make-deps-tab-configurable into df12ead on jaegertracing:master.

@yurishkuro yurishkuro merged commit 3522365 into jaegertracing:master Nov 27, 2017
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants