Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #96 - problem with Jest and watchman #100

Closed
wants to merge 3 commits into from

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Oct 23, 2017

Fix #96. Non-functional change.

Was able to reproduce #96 locally with:

yarn test -- --no-watchman

Issue stems from something specific to jest pre jest@20.1.0-alpha.3, apparently.

A way to resolve the issue is:

brew install watchman

Or, upgrading jest resolved the issue (when running with --no-watchman).

Only precarious thing about upgrading jest is it is now pinned in the repo instead of implied by react-scripts (the latest version of which uses jest@20.0.4). So, the install should be reverted when react-scripts comes around to having the newer version of jest.

Signed-off-by: Joe Farro <joe@jf.io>
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon closed this Oct 23, 2017
@tiffon tiffon deleted the issue-96-jest-watchman branch October 23, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail
2 participants