Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit use of lerna #341

Closed
tiffon opened this issue Mar 8, 2019 · 0 comments · Fixed by #1997
Closed

Audit use of lerna #341

tiffon opened this issue Mar 8, 2019 · 0 comments · Fixed by #1997

Comments

@tiffon
Copy link
Member

tiffon commented Mar 8, 2019

Make sure our use of lerna is:

  • Necessary
  • Idiomatic (if it is necessary)

We have ended up relying quite a bit on yarn workspaces, which has reduced the relevance of lerna.

yurishkuro pushed a commit that referenced this issue Nov 23, 2023
## Which problem is this PR solving?
lerna/nx does not support s390x, and therefore the jaeger-ui build fails
on this platform. This PR removes the lerna dependency from jaeger-ui.


https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161

https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms

Resolves: #1996
Resolves: #341

## Description of the changes
Remove `lerna` and use `yarn workspaces` instead. 

## How was this change tested?
- local

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant