Remove dependency on isomorphic-fetch (#1616)

jaegertracing · Aug 2, 2023 · ffe3f7f · ffe3f7f
1 parent f559122
commit ffe3f7f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -18,7 +18,6 @@
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-react": "7.32.2",
     "husky": "8.0.3",
-    "isomorphic-fetch": "3.0.0",
     "jsdom": "22.1.0",
     "lerna": "7.1.3",
     "npm-run-all": "4.1.5",

diff --git a/scripts/get-changelog.js b/scripts/get-changelog.js
@@ -16,14 +16,11 @@
 
 // This code will generate changelog entries
 
-const { readFile } = require('fs');
-// eslint-disable-next-line import/no-extraneous-dependencies
-const fetch = require('isomorphic-fetch');
+const { readFile } = require('fs').promises;
 // eslint-disable-next-line import/no-extraneous-dependencies
 const jsdom = require('jsdom');
-const { promisify } = require('util');
 
-const readFilePromise = promisify(readFile);
+const readFilePromise = readFile;
 
 const DOMAIN = 'https://github.com/';
 const JAEGER_REPO = process.env.JAEGER_REPO || 'jaeger-ui';

diff --git a/yarn.lock b/yarn.lock
@@ -7440,21 +7440,21 @@ isobject@^3.0.1:
   resolved "https://registry.yarnpkg.com/isobject/-/isobject-3.0.1.tgz#4e431e92b11a9731636aa1f9c8d1ccbcfdab78df"
   integrity sha1-TkMekrEalzFjaqH5yNHMvP2reN8=
 
-isomorphic-fetch@3.0.0, isomorphic-fetch@^3.0.0:
-  version "3.0.0"
-  resolved "https://registry.yarnpkg.com/isomorphic-fetch/-/isomorphic-fetch-3.0.0.tgz#0267b005049046d2421207215d45d6a262b8b8b4"
-  integrity sha512-qvUtwJ3j6qwsF3jLxkZ72qCgjMysPzDfeV240JHiGZsANBYd+EEuu35v7dfrJ9Up0Ak07D7GGSkGhCHTqg/5wA==
-  dependencies:
-    node-fetch "^2.6.1"
-    whatwg-fetch "^3.4.1"
-
 isomorphic-fetch@^2.1.1:
   version "2.2.1"
   resolved "https://registry.yarnpkg.com/isomorphic-fetch/-/isomorphic-fetch-2.2.1.tgz#611ae1acf14f5e81f729507472819fe9733558a9"
   dependencies:
     node-fetch "^1.0.1"
     whatwg-fetch ">=0.10.0"
 
+isomorphic-fetch@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/isomorphic-fetch/-/isomorphic-fetch-3.0.0.tgz#0267b005049046d2421207215d45d6a262b8b8b4"
+  integrity sha512-qvUtwJ3j6qwsF3jLxkZ72qCgjMysPzDfeV240JHiGZsANBYd+EEuu35v7dfrJ9Up0Ak07D7GGSkGhCHTqg/5wA==
+  dependencies:
+    node-fetch "^2.6.1"
+    whatwg-fetch "^3.4.1"
+
 istanbul-lib-coverage@^3.0.0, istanbul-lib-coverage@^3.2.0:
   version "3.2.0"
   resolved "https://registry.yarnpkg.com/istanbul-lib-coverage/-/istanbul-lib-coverage-3.2.0.tgz#189e7909d0a39fa5a3dfad5b03f71947770191d3"