Minor changes to a comment and a test case description

jaegertracing · Aug 30, 2017 · f45d360 · f45d360
1 parent cd45e62
commit f45d360
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/TracePage/TraceTimelineViewer/ListView/index.js b/src/components/TracePage/TraceTimelineViewer/ListView/index.js
@@ -375,7 +375,7 @@ export default class ListView extends React.Component<ListViewProps> {
     const max = nodes.length;
     for (let i = 0; i < max; i++) {
       const node: HTMLElement = (nodes[i]: any);
-      // const itemKey = node.dataset.itemKey;
+      // use `.getAttribute(...)` instead of `.dataset` for jest / JSDOM
       const itemKey = node.getAttribute('data-item-key');
       if (!itemKey) {
         // eslint-disable-next-line no-console

diff --git a/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js b/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js
@@ -134,7 +134,7 @@ describe('<ListView>', () => {
         windowAddListenerSpy.mockRestore();
       });
 
-      it('adds the onScroll listener to the root HTML element after it mounts', () => {
+      it('adds the onScroll listener to the window element after the component mounts', () => {
         expect(windowAddListenerSpy).toHaveBeenCalled();
         expect(windowAddListenerSpy).toHaveBeenLastCalledWith('scroll', instance._onScroll);
       });