-
Notifications
You must be signed in to change notification settings - Fork 482
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support hierarchical error span highlighting (#18)
- Loading branch information
1 parent
4429225
commit 5376087
Showing
3 changed files
with
94 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
src/components/TracePage/TraceTimelineViewer/utils.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
// Copyright (c) 2017 Uber Technologies, Inc. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
|
||
import { spanContainsErredSpan } from './utils'; | ||
import traceGenerator from '../../../demo/trace-generators'; | ||
|
||
it('spanContainsErredSpan(...) is true only when a descendant has an error tag', () => { | ||
const errorTag = { key: 'error', type: 'bool', value: true }; | ||
const getTags = withError => | ||
withError ? traceGenerator.tags().concat(errorTag) : traceGenerator.tags(); | ||
|
||
// Using a string to generate the test spans. Each line results in a span. The | ||
// left number indicates whether or not the generated span has a descendant | ||
// with an error tag (the expectation). The length of the line indicates the | ||
// depth of the span (i.e. further right is higher depth). The right number | ||
// indicates whether or not the span has an error tag. | ||
const config = ` | ||
1 0 | ||
1 0 | ||
0 1 | ||
0 0 | ||
1 0 | ||
1 1 | ||
0 1 | ||
0 0 | ||
1 0 | ||
0 1 | ||
0 0 | ||
` | ||
.trim() | ||
.split('\n') | ||
.map(s => s.trim()); | ||
// Get the expectation, str -> number -> bool | ||
const expectations = config.map(s => Boolean(Number(s[0]))); | ||
const spans = config.map(line => ({ | ||
depth: line.length, | ||
tags: getTags(+line.slice(-1)), | ||
})); | ||
|
||
expectations.forEach((target, i) => { | ||
// include the index in the expect condition to know which span failed | ||
// (if there is a failure, that is) | ||
const result = [i, spanContainsErredSpan(spans, i)]; | ||
expect(result).toEqual([i, target]); | ||
}); | ||
}); |