Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies to Kube 0.28.1 #2301

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Update go dependencies to Kube 0.28.1 #2301

merged 2 commits into from
Sep 1, 2023

Conversation

pavolloffay
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch coverage is 88.88% of modified lines.

❗ Current head 56ece01 differs from pull request most recent head b43bd45. Consider uploading reports for the commit b43bd45 to get more accurate results

Files Changed Coverage
apis/v1/jaeger_types.go ø
pkg/autodetect/operatorconfig.go 85.18%
pkg/autodetect/main.go 100.00%
pkg/controller/jaeger/jaeger_controller.go 100.00%

📢 Thoughts on this report? Let us know!.

pavolloffay
pavolloffay commented Aug 29, 2023
View reviewed changes
pkg/cmd/start/bootstrap.go
Namespaces: strings.Split(namespace, ","),
}
Cache: cache.Options{
DefaultNamespaces: namespaces,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test miscellaneous_non_cluster_wide seems to be failing. It might be related to how the default namespaces are set

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue seems to be related to running kind 1.28

@pavolloffay pavolloffay changed the title Update dependencies to Kube 0.28.1 Update go dependencies to Kube 0.28.1 Aug 29, 2023
@pavolloffay
Update dependencies to Kube 0.28.1
a5a8d0f 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Fix
b43bd45 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

@pavolloffay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jaeger-e2e-tests b43bd45 link true /test jaeger-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pavolloffay pavolloffay merged commit cc65553 into jaegertracing:main Sep 1, 2023
21 of 23 checks passed
iblancasa pushed a commit to iblancasa/jaeger-operator that referenced this pull request Sep 4, 2023
@pavolloffay @iblancasa
Update go dependencies to Kube 0.28.1 (jaegertracing#2301)
6efd647 
* Update dependencies to Kube 0.28.1

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

---------

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblancasa iblancasa iblancasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavolloffay @iblancasa