Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the TokenReview after checking we can create it #2286

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

iblancasa
Copy link
Collaborator

Resolves #2285.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dde9e07) 87.68% compared to head (591245f) 87.68%.

❗ Current head 591245f differs from pull request most recent head 6444430. Consider uploading reports for the commit 6444430 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2286   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         101      101           
  Lines        7129     7131    +2     
=======================================
+ Hits         6251     6253    +2     
  Misses        681      681           
  Partials      197      197           
Files Changed Coverage Δ
pkg/autodetect/main.go 81.49% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa iblancasa added the bug Something isn't working label Aug 9, 2023
@rubenvp8510 rubenvp8510 merged commit 129f24a into jaegertracing:main Aug 9, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth-delegator-available fails sometimes because the jaeger-operator-TEST TokenReview is already there
2 participants