-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom labels for the deployable components in production strategy #2277
Conversation
Signed-off-by: hiteshwani29 <hiteshwani29@gmail.com>
Hi @hiteshwani29. Thanks for your PR. I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
55f3b14
to
195bae9
Compare
@hiteshwani29 the linting is failing. You can check what is failing with |
Signed-off-by: hiteshwani29 <hiteshwani29@gmail.com>
195bae9
to
2c531c2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 87.68% 87.58% -0.11%
==========================================
Files 100 100
Lines 6985 7009 +24
==========================================
+ Hits 6125 6139 +14
- Misses 656 666 +10
Partials 204 204
☔ View full report in Codecov by Sentry. |
/retest-required |
Which problem is this PR solving?
production
strategy #1531Short description of the changes