Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for min tls version to v1.2 #2119

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Conversation

kangsheng89
Copy link
Contributor

Which problem is this PR solving?

Fix #2118

Short description of the changes

Adding min tls version for webhook server during bootstraping

Signed-off-by: kangsheng89 <ks_wong_89@hotmail.com>
@kangsheng89
Copy link
Contributor Author

kangsheng89 commented Nov 16, 2022

after fix on my local, with portforward to 10001, clearly observed webhook server port 9443 is enabled with min TLSv1.2
image

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 87.32% // Head: 87.32% // No change to project coverage 👍

Coverage data is based on head (19b0264) compared to base (06e6e4d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         100      100           
  Lines        6865     6865           
=======================================
  Hits         5995     5995           
  Misses        667      667           
  Partials      203      203           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/cmd/start/bootstrap.go Outdated Show resolved Hide resolved
Signed-off-by: kangsheng89 <ks_wong_89@hotmail.com>
frzifus
frzifus previously approved these changes Nov 17, 2022
@frzifus
Copy link
Member

frzifus commented Nov 17, 2022

wdyt @rubenvp8510 ?

@kangsheng89
Copy link
Contributor Author

@frzifus i will update for TLS cipher as well. Hehe pending..LOL

Signed-off-by: kangsheng89 <ks_wong_89@hotmail.com>
@rubenvp8510
Copy link
Collaborator

This looks good to me!

@frzifus frzifus enabled auto-merge (squash) November 17, 2022 03:11
@kangsheng89
Copy link
Contributor Author

kangsheng89 commented Nov 17, 2022

currently the CICD is failing
+---------------------------------------------------------+--------+
| NAME | RESULT |
+---------------------------------------------------------+--------+
| examples/examples_simple_prod | passed |
| examples/examples_with_sampling | passed |
| examples/examples_with_cassandra | passed |
| examples/examples_with_badger_and_volume | passed |
| examples/examples_with_badger | passed |
| examples/examples_simplest | passed |
| examples/examples_simple_prod_with_volumes | passed |
| examples/examples_auto_provision_kafka | passed |
| examples/examples_service_types | passed |
| examples/examples_collector_with_priority_class | passed |
| examples/examples_business_application_injected_sidecar | passed |
| examples/examples_agent_with_priority_class | passed |
| examples/examples_all_in_one_with_options | failed |
| examples/examples_agent_as_daemonset | passed |
+---------------------------------------------------------+--------+

@frzifus can u point me on how i can fix this?

@kangsheng89
Copy link
Contributor Author

@frzifus can help to rerun the CICD pipeline?

@frzifus frzifus merged commit 8820ea5 into jaegertracing:main Nov 22, 2022
@kangsheng89 kangsheng89 deleted the mintls branch November 22, 2022 09:36
@frzifus
Copy link
Member

frzifus commented Nov 22, 2022

@kangsheng89 it did already pass :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: min tls setting for webhook server
3 participants