This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Allow to set custom hostname(address) for jaeger agent. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This is intended to be used when application using jaeger-client-python is running as a container and needs to communicate with jaeger agent running on same host either natively or inside a container. Specifying a remote agent address ( different host) won't work reliably.
|
|
|
@bharat-p TYVM for taking this on...my apologies for disappearing! Much appreciated. |
|
Any updates on this? |
|
@yurishkuro PR is ready not sure why license/cla check is still pending. |
|
Thanks, all, for this PR. Should this field be mentioned in the documentation somewhere, since you were looking at it recently? |
djshen-ponddy
added a commit
to djshen-ponddy/jaeger-client-python
that referenced
this pull request
Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
This is intended to be used when application using jaeger-client-python is running as a container and needs to communicate with jaeger agent running on same host either natively or inside a container.
Specifying a remote agent address ( different host) won't work reliably.
This is same as PR opened by @bendemaree with added UT for new config test.