This repository has been archived by the owner on May 23, 2024. It is now read-only.
Allow config.FromEnv() to enrich an existing config object #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an other method with config receiver and modified the existing method to call the method with config receiver. Resolves: 430 Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
yurishkuro
suggested changes
Sep 29, 2019
There was a problem hiding this comment.
Thanks for the PR.
I think this change is not enough though. If you look at the end of this function, samplerConfigFromEnv() and reporterConfigFromEnv() completely override c.Sampler and c.Reporter. Those helper functions also need to be changed to allow inflating the existing configurations.
If you add unit tests for config + env, you'd see it.
2 tasks
…tests. Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
golangcibot
reviewed
Oct 1, 2019
yurishkuro
reviewed
Oct 1, 2019
| assert.Equal(t, false, cfg.Disabled) | ||
| assert.Equal(t, true, cfg.RPCMetrics) | ||
| assert.Equal(t, "KEY", cfg.Tags[0].Key) | ||
| assert.Equal(t, "VALUE", cfg.Tags[0].Value) |
There was a problem hiding this comment.
I suggest to change this test to be more comprehensive, as follows:
- manually initialize Config struct (as you do already)
- do not set any env vars, just call
cfg.FromEnvand assert that the values remained as configured - set env vars, call cfg.FromEnv again
- assert that values changed
Right now the test is missing step 2.
There was a problem hiding this comment.
I added the required validation in the unit test.
… tests Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com> made chnages to support allow FromEnv for sampler and reporter + Unit tests Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
yurishkuro
reviewed
Oct 2, 2019
Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
Signed-off-by: vineeth <vineeth.pothulapati@aquasec.com>
yurishkuro
approved these changes
Oct 2, 2019
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Signed-off-by: vineeth vineeth.pothulapati@aquasec.com
Resolves: #430