-
Notifications
You must be signed in to change notification settings - Fork 24
Grafana dashboard for trace quality #22
Grafana dashboard for trace quality #22
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Makefile
Outdated
.PHONY: grafana-run | ||
grafana-run: | ||
echo "Open browser on :3000" | ||
docker run --rm -it --net=host grafana/grafana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: A config file and the dashboard.json can be mounted on the container directly!
Ref - https://grafana.com/docs/grafana/latest/administration/provisioning/#dashboards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a config file for datasource and dashboards. In the tracequality dashboard I hardcoded datasource Prometheus
. We can change this once we introduce mixins.
dashboards/Grafana-tracequality.json
Outdated
@@ -0,0 +1,476 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard creation can be templated through the mixin (we can use it for future releases if dashboards get bigger)
Ref- jaegertracing/jaeger#1668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I think we could have more dashboards.
A dashboard I am thinking about would show other derived metrics from traces per service. We could also define alerts for these metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if users would need alerts on these metrics, but definitely +1 for dashboards.
@annanay25 the dashboard has one configurable variable - service. Do you know if grafana can be configured to search possible values of this variable based on the Prometheus metric label? |
@pavolloffay - Yes, this is definitely possible. References - |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
I will merge this and create issue to populate label values to service dropdown. |
Strange, I'll try getting it working on my local machine and get back |
Resolves #16
@annanay25 could you please have a look?
Signed-off-by: Pavol Loffay ploffay@redhat.com