[jaeger] Add securityContext for the oauth sidecar in query-deploy.yaml #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elukey
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
elukey
changed the title
|
@elukey could you, please, go through the PR checklist? Thank you 🙏 |
elukey
force-pushed
the
main
branch
3 times, most recently
from
a940426 to
a6f8977
Compare
The sidecar is missing the securityContext entry, and it makes it difficult to apply specific settings in the context of K8s PSS (migrating from PSP for example). Signed-off-by: Luca Toscano <ltoscano@wikimedia.org>
|
@pavelnikolov Done! Sorry :) |
pavelnikolov
approved these changes
Sep 11, 2024
K3ndu
pushed a commit
to K3ndu/helm-charts
that referenced
this pull request
Sep 12, 2024
…ml (jaegertracing#600) The sidecar is missing the securityContext entry, and it makes it difficult to apply specific settings in the context of K8s PSS (migrating from PSP for example). Signed-off-by: Luca Toscano <ltoscano@wikimedia.org> Signed-off-by: Kendi Paet <kendi@tavex.eu>
hellspawn679
pushed a commit
to hellspawn679/helm-charts
that referenced
this pull request
Nov 1, 2024
…ml (jaegertracing#600) The sidecar is missing the securityContext entry, and it makes it difficult to apply specific settings in the context of K8s PSS (migrating from PSP for example). Signed-off-by: Luca Toscano <ltoscano@wikimedia.org> Signed-off-by: mehul <mehulsharam4786@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The sidecar is missing the securityContext entry, and it makes it difficult to apply specific settings in the context of K8s PSS (migrating from PSP for example).
Checklist
[jaeger]or[jaeger-operator])