[jaeger] Add ability to edit port name and target port name in query and collector services #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishukamble
force-pushed
the
feature-collector-query-svc-name-change
branch
2 times, most recently
from
7276c9c to
e912cb4
Compare
vishukamble
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
|
Could you, please, GPG-sign the commits and bump the chart version? |
vishukamble
force-pushed
the
feature-collector-query-svc-name-change
branch
from
f04e427 to
31756b1
Compare
…n port at 14269 Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
…rt at 16687 Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
… template Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
vishukamble
force-pushed
the
feature-collector-query-svc-name-change
branch
from
0ce0817 to
530ed46
Compare
Signed-off-by: Vishu Kamble <vishu.mb@gmail.com>
|
@pavelnikolov can you please let me know if everything looks good now. |
hellspawn679
pushed a commit
to hellspawn679/helm-charts
that referenced
this pull request
Nov 1, 2024
…and collector services (jaegertracing#590) Signed-off-by: mehul <mehulsharam4786@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the ability to edit the port name and target port name in the Jaeger query and collector services. This enhancement allows users to customize the port names, which is useful for enforcing HTTPS via Istio by renaming the port with the prefix http.
Which issue this PR fixes
This PR fixes issue #589.
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])