[jaeger] make Deployment depend on oauth2 config, if enabled #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdanis
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
Signed-off-by: Chris Danis <cdanis@wikimedia.org>
cdanis
force-pushed
the
oauth2-config-deploy
branch
from
4884f0e to
d63e5c1
Compare
antonioberben
pushed a commit
to antonioberben/jaeger-helm-charts
that referenced
this pull request
Feb 26, 2024
…racing#541) Signed-off-by: Chris Danis <cdanis@wikimedia.org> Signed-off-by: Antonio Berben <antonio.berben@solo.io>
antonioberben
pushed a commit
to antonioberben/jaeger-helm-charts
that referenced
this pull request
Feb 26, 2024
…racing#541) Signed-off-by: Chris Danis <cdanis@wikimedia.org> Signed-off-by: Antonio Berben <antonio.berben@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Without this, changes to the oauth2-proxy configuration don't affect any metadata in the Deployment, meaning pods must be deleted manually after a configuration change.
Checklist
[jaeger]or[jaeger-operator])