[jaeger] fixes #329 missing prefix on esCronJobs #414
Conversation
Mouness
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
|
Hi @mehta-ankit, |
Mouness
force-pushed
the
esIndexCleaner_add_extra_args
branch
from
2c7c795 to
d43c172
Compare
Mouness
requested review from
mehta-ankit
and removed request for
pavelnikolov,
davidvonthenen and
naseemkullah
|
Hi anybody to check this PR, please? |
looking into it |
|
@Mouness can you maybe please squash commits into 1 commit and gpg sign the commit (currently you have 3 commits and 2 are not gpg signed). Thanks |
Mouness
force-pushed
the
esIndexCleaner_add_extra_args
branch
6 times, most recently
from
3d350a9 to
bc082c2
Compare
|
Hi @mehta-ankit , |
Signed-off-by: Mounir <mounir.arrahmani@outlook.com>
Mouness
force-pushed
the
esIndexCleaner_add_extra_args
branch
from
bc082c2 to
2ec9b7f
Compare
|
Sorry for the back and forth I had to setup gpg locally |
no problem. Thanks a lot for squashing them 😄 (i appreciate it) |
| @@ -34,7 +34,7 @@ dependencies: | |||
| repository: https://helm.elastic.co | |||
| condition: provisionDataStore.elasticsearch | |||
| - name: kafka | |||
| version: ^19.1.5 | |||
| version: ^18.0.8 | |||
There was a problem hiding this comment.
Why was this reverted to 18.x?
There was a problem hiding this comment.
@gburton1 If i have to guess it would have been an oversight and not an intentional change. Maybe during squashing of the commits/resolving conflicts in this MR, this change got in.
There was a problem hiding this comment.
Hi @gburton1, it was not intentional. It probably happened during the squash. Do you want to create a new PR to revert this change?
What this PR does
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])