Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use google.golang.org/protobuf v1.31.0 #28

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Use google.golang.org/protobuf v1.31.0 #28

merged 1 commit into from
Nov 3, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 3, 2023 •
edited by yurishkuro
Loading

Summary

Part of jaegertracing/jaeger#4911

migrate from github.com/golang/protobuf to google.golang.org/protobuf

Changes

  • Uses google.golang.org/protobuf with 1.31.0 version

@mmorel-35 mmorel-35 mentioned this pull request Nov 3, 2023
Merged
4 tasks
@yurishkuro
Copy link
Member

did you test this image by building locally and running with it in jaeger-idl?

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 3, 2023 •
edited
Loading

@yurishkuro ,
The build is passing , I have to try it on jaeger-idl now.

I upgraded go version to be able to use go install to avoid building binaries from sources

@mmorel-35 mmorel-35 marked this pull request as draft November 3, 2023 15:34
@mmorel-35
use google.golang.org/protobuf instead of github.com/golang/protobuf
ff2572d 
use go install
Upgrade golang to 1.17.3

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review November 3, 2023 20:17
@yurishkuro
Copy link
Member

tested on a cloud Linux box

  • docker build . -t build
  • then go to jaeger-idl, and run make test-ci PROTOC_IMAGE=build - successful

@yurishkuro yurishkuro merged commit 3ad2c52 into jaegertracing:master Nov 3, 2023
3 checks passed
@yurishkuro yurishkuro changed the title migrate from github.com/golang/protobuf to google.golang.org/protobuf Use google.golang.org/protobuf v1.31.0 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @yurishkuro