Removing pycbc and simplifiyng dependencies #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amongst other things, this PR fixes https://github.com/jacopok/mlgw_bns/security/dependabot/6.
Also, it fixes #35 and #34.
The mismatches had to be computed by narrowing the PSD range to the training range of the model - the results were not awful otherwise, but they did go above the
< 1e-5threshold I'd set for the default provided model.This PR fixes a lot of the warnings the test suite was giving, which were mainly due to incompatibility in the numpy C API with older versions of scipy, matplotlib and such which were required by pycbc.
Further, it makes the
pyproject.tomlcompliant with poetry 1.2.