Switch to syscall.Open on Darwin #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsa
requested changes
Feb 11, 2018
| @@ -80,6 +80,22 @@ type termios struct { | |||
| c_ispeed speed_t | |||
| c_ospeed speed_t | |||
| } | |||
| type Port struct{ | |||
| @@ -80,6 +80,22 @@ type termios struct { | |||
| c_ispeed speed_t | |||
| c_ospeed speed_t | |||
| } | |||
| type Port struct{ | |||
There was a problem hiding this comment.
This shouldn't be exported (i.e. capitalized).
| @@ -231,7 +247,7 @@ func openInternal(options OpenOptions) (io.ReadWriteCloser, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
You need to ensure that the FD isn't leaked if you return early below.
|
I'll look at your comments, but right now, it seems that there are other issues like some of the flags not being set in termios. Still trying to debug. |
|
For example, the termios struct you define has a byte array of 20, which is not aligned on 64 bits. This is why the unix.termios has a padding array of 4 bytes. One the issues I see for example is that rtscts doesn't get applied to the serial port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolve the high cpu caused by os.OpenFile as described here: golang/go#22099