This repository has been archived by the owner on May 1, 2022. It is now read-only.
Fix missing web_module check for dynamic imports #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the solution
When a svelte file contained a dynamic import like
const HomePage = () => import('/pages/Home/index');
, the snowpack check for missing web_modules would always fail becausees-module-lexer
seems to have the paths wrapped in quotes I guess.