This repository has been archived by the owner on May 1, 2022. It is now read-only.
Fix snowpack babel error #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowpack released 1.2.0 which changed their babel plugin logic a bit. https://github.com/pikapkg/snowpack/pull/189/files#diff-dbcfdbbaf972e7b385fa6fcb270a59d9R60 Since we use their babel plugin, this broke our babel transform step. Fixed by using the new `importMap` option and specifying where to look for it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this fix?
Closes #37
Describe the solution
Snowpack released 1.2.0 which changed their babel plugin logic a bit. https://github.com/pikapkg/snowpack/pull/189/files#diff-dbcfdbbaf972e7b385fa6fcb270a59d9R60
Since we use their babel plugin, this broke our babel transform step.
Fixed by using the new
importMapoption and specifying where to look for it.Also locked down snowpack to a specific version to prevent future breakages. Need to bump that for every new release they do.