fixed issue #12 and refactored how unifi processes are run #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed missing symlinks for data, log and run dirs. Refactored to use dumb-init, a small wrapper script and jsvc to better match how the original debian package runs the software. Pushed in openjdk headless java-8 and removed external dependany on mongo.org (debain repo version for mongodb was adequet).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing symlinks for data, log and run dirs. Refactored to use dumb-init, a small wrapper script and jsvc to better match how the original debian package runs the software. Pushed in openjdk headless java-8 and removed external dependany on mongo.org (debain repo version for mongodb was adequet).
Tested as working for me from within a docker container. Logs, etc now using the correct directories. The
RUN ln...is important.Some of the other changes conflict with a microservice philosophy with or have added extra processes into the container, but IMO, it might be safer to mimic the way the debian package intends running the controller software (at least until it's clear upstream has refactored the app to work well within docker).